Analyzed various character ex-field; Added Player::TrailImage - #29
Open
jyanf wants to merge 20 commits into
Open
Analyzed various character ex-field; Added Player::TrailImage#29jyanf wants to merge 20 commits into
jyanf wants to merge 20 commits into
Conversation
adjusted tenshi's field signedness
suwako and iku fields supplement some unsure/unused fields are retyped by checking init vfunc
renamed suwako 0x891 bool
jyanf
changed the title
alice ex-fields supplement
added marisa ex-fields
fixed trailImage naming in test/main
added yukari and yuyuko's extra fields
"unleashSignal" renamed
PinkySmile
requested changes
Sep 5, 2026
|
|
||
| float orreriesRotatePhase;// -=speed | ||
| float orreriesRotateSpeed;//type0: 3, type1: 12, type8: 0.5, type50: 12 | ||
| float orreriesThrowTargetX, orreriesThrowTargetY;//record decided target pos when throwing out |
| reinterpret_cast<void (__fastcall*)(void*)>(0x433a50)(&this->unknownObject); | ||
| // clone buffer clear | ||
| //reinterpret_cast<void (__fastcall*)(void*)>(0x433a50)(&this->cloneBuffer); | ||
| this->cloneBuffer.clear(); |
Member
There was a problem hiding this comment.
~Deque already clears so I don't think it's required. Keeping the old code also is redundant with the git.
| Player(info) | ||
| { | ||
| memset(this->unknown8C0, 0, 0x10); // [0x8c0-0x8d0] = 0 | ||
| //memset(&this->cloneBuffer.m_table, 0, 0x10); |
PinkySmile
approved these changes
Sep 5, 2026
Member
|
I'll test it against CharacterEngine and see if anything breaks before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.